[763] remove orderdiscount model

dancerfly / django-brambling

Event website manager, specifically designed for dance weekends or other events with multiple simultaneous tracks of classes.

BSD 3-Clause "New" or "Revised" License

11 stars 3 forks source link

[763] remove orderdiscount model #924

Closed melinath closed 5 years ago

melinath commented 5 years ago

Removed OrderDiscount model and made it so that:

Adding items to cart does not automatically add discounts to them.
Adding discounts to the order adds them to any bought items that don't have them yet (instead of only adding them the first time the discount is applied)

This is the second phase of #763. I think it can be deployed in parallel with #923 since if this ships first it will result in discounts just never being displayed in the shop, which is fine.

harrislapiroff commented 5 years ago

ohhhhhh discounts were already associated with an item it’s just that we previously added them to every matching item in the cart? Interesting interetesting

melinath commented 5 years ago

Yeah we had a concept of the discount being added to the order (in addition to being added to each item individually) and it turns out it was a bad idea nobody wanted :joy:

harrislapiroff commented 5 years ago

Oh I see. Even with this PR it still adds to all current items in the cart, but it doesn't add to past and future checkout processes. Is that correct?

melinath commented 5 years ago

Yes, that's exactly correct :-)