search

danchoi / vmail

a vim interface for gmail
http://danielchoi.com/software/vmail.html
MIT License
786 stars 59 forks source link

Adding 'o' key for Open/Close message window #182

Closed lzap closed 10 years ago

lzap commented 10 years ago

So here is the thing. I consider Enter as a "too far" key (which is stressed by my right-hand RSI). Since o key is unused for both message list and view (both buffers are read-only), this patch adds Open and Close Message Window mappings.

This is quick way of opening and closing (for consistency with Space/Enter) messages. I like this very much and hope you will like it too.

If you are happy with the change, I will go ahead and add this mapping to the wiki (list of keys page I suppose).

Vmail looks like my primary MUA now (happy Mutt user). I would like to help implementing two missing things which I consider as "blockers" for me:

Good stuff guys!

notalex commented 10 years ago

@lzap, I like the idea. I am usually on a laptop and would like a larger message window, so mapping to VmailOpenLargeMessage would work better for me. We could make the VmailOpenMessage and VmailOpenLargeMessage functions public. This way one can map using a ftplugin. Would that work for you?

lzap commented 10 years ago

How about shift with o for large?

notalex commented 10 years ago

That will work for me. It would be great if you could update this PR with the additional mapping. The wiki page is here.

lzap commented 10 years ago

But I don't see any VmailOpenLargeMessage function in master. What should I bind the O key to?

notalex commented 10 years ago

Sorry @lzap, it is in another patch which I was working upon. I will add that mapping myself.

lzap commented 10 years ago

Awesome, thanks!