search

danchoi / vmail

a vim interface for gmail
http://danielchoi.com/software/vmail.html
MIT License
786 stars 60 forks source link

add def has_clientserver? & def vim from vmail.rb #212

Closed marskar closed 6 years ago

marskar commented 6 years ago

This is a pull request in response to issue https://github.com/danchoi/vmail/issues/209. After applying the solution suggested by @PedroLopes, updating now works for me on mac osx with the following specs: VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Jul 26 2017 19:10:24) vmail 2.9.8 (from gem)

It may be preferable to use the habpy version of vmail (which I believe arose from issue https://github.com/danchoi/vmail/issues/199), as @PedroLopes suggested, but I think the solution in this pull request is the simplest and cleanest fix.

notalex commented 6 years ago

I apologize for the delay. I didn't have osx to test this with, so it just kept getting delayed. But the change seems trivial, so we can merge it. Thanks for your patch and your workaround for clientserver. I will be adding a link to it in the Readme.