search

dancryer / PHPCI

PHPCI is a free and open source continuous integration tool specifically designed for PHP.
BSD 2-Clause "Simplified" License
2.42k stars 439 forks source link

Wrong branch reported for build #1059

Open danaketh opened 9 years ago

danaketh commented 9 years ago

When multiple commits are pushed, for some reason all except the last one are marked as made from master instead of the branch they're really in.

It's actually a bug on both sides - BitBucket and PHPCI. Their payload carries the branch information only for the last commit. In all other commits it's omitted. PHPCI takes the null value for branch in the payload as master.

I'm not sure if it's safe to assume that all commits in the push are coming from the same branch since there is a way to push everything at once and I have no idea how git (and BitBucket) will handle that. Will test what pushing more branches at once will do.

dancryer commented 9 years ago

We need to update PHPCI to support Bitbucket's new webhooks anyway, so perhaps this issue will be resolved then. :)