dancryer / PHPCI

PHPCI is a free and open source continuous integration tool specifically designed for PHP.
BSD 2-Clause "Simplified" License
2.42k stars 439 forks source link

Quality trend chart not parsing missing data correctly #1221

Closed mxcoder closed 2 years ago

mxcoder commented 8 years ago

Expected behaviour

When some of the chart-enabled plugins are not run, the chart code is still trying to read the value of these. Ideally this should just either disable that line in the chart or present it as zero points in it. image

Actual behaviour

Lines are not being correctly rendered because while reading these missing values parseInt is being used, which returns a NaN value. chartJS doesn't seem to play ok with these. image

Steps to reproduce

Run any build with at least one of these not present in the chart data: 'codeception-errors' 'phplint-errors' 'phpunit-errors' 'phptallint-errors' 'phptallint-warnings' 'phpcs-errors' A single line (pink) will be shown, flat on zeros.

Environment info

Operating System: Ubuntu 14 PHP Version: 5.5.9 MySQL Version: 5.5.44