search

dancryer / PHPCI

PHPCI is a free and open source continuous integration tool specifically designed for PHP.
BSD 2-Clause "Simplified" License
2.42k stars 441 forks source link

Ignores any builds after a seemingly random number of commits in a PR #1225

Open asgrim opened 8 years ago

asgrim commented 8 years ago

When working with a long PR with many commits, eventually PHPCI seems to give up building when new commits are pushed to the branch.

Expected behaviour

A build should happen for the latest commit ideally (separate issue: #656), but with current behaviour I'd expect to see a build created for every commit.

Actual behaviour

After a random number of commits, no subsequent builds happen.

Steps to reproduce

Create a pull request from a branch, keep adding commits until eventually PHPCI gives up.

Environment info

Operating System: AS/400 (IBM i) PHP Version: 5.6.7

Logs or other output that would be helpful

(If logs are large, please upload as attachment).

asgrim commented 8 years ago

9f6bb7

asgrim commented 8 years ago

6068e8

Looks like this may be caused by service timeouts. Whatever PHPCI is doing, it's taking longer than 30 seconds (the timeout for webhook deliveries) to queue up the builds. If I keep clicking "Redeliver" on the failed hook, eventually PHPCI creates the missing builds. This could probably be solved by #656 anyway, because we don't need all the interim commits to have build statuses in our situation anyway.