dancryer / PHPCI

PHPCI is a free and open source continuous integration tool specifically designed for PHP.
BSD 2-Clause "Simplified" License
2.42k stars 439 forks source link

It is possible to run worker threads without PHPCI knowing about it #1231

Closed asgrim closed 8 years ago

asgrim commented 8 years ago

Running two worker threads means that the original PID gets "lost" essentially, so PHPCI no longer knows about it. This means a ghostly worker thread is still running, but using ./console phpci:daemon stop won't kill it.

Expected behaviour

I expect PHPCI to properly track processes it is running and to stop them so I don't have to manually hunt through the process list and kill them.

Actual behaviour

There are PHPCI worker processes that can only be killed by looking at them in the process list and manually killing them.

Steps to reproduce

Operating System: IBM i / AIX PHP Version: 5.6

dancryer commented 8 years ago

Going forward, the recommended way to manage this is to use the worker mode instead, and use a proper process manager like supervisord to manage it.

https://github.com/Block8/PHPCI/wiki/Run-Builds-Using-a-Worker