dancryer / PHPCI

PHPCI is a free and open source continuous integration tool specifically designed for PHP.
BSD 2-Clause "Simplified" License
2.42k stars 441 forks source link

Removing PHPUnit::execute Coverage Tags #1258

Closed Fenikkusu closed 7 years ago

Fenikkusu commented 8 years ago

Contribution Type: bug fix Link to Bug: https://github.com/Block8/PHPCI/issues/1250

This pull request affects the following areas:

In raising this pull request, I confirm the following (please check boxes):

Detailed description of change:

Removed the @covers PHPUnit::execute declaration - no such thing exists in the code and code coverage testing will not finish otherwise.

Fenikkusu commented 8 years ago

Note: While regular unit tests pass, I'm coming across a odd issue when running the code coverage testing. For what ever reason, BuildLoggerTest::testLogFailure_AddsExceptionContext will not complete if running all tests. If running just the single test, the test completes fine. I'm not sure what is going on here. The only thing I've noticed is an error in PHPStorm indicating an additional attempted connection failed.