dancryer / PHPCI

PHPCI is a free and open source continuous integration tool specifically designed for PHP.
BSD 2-Clause "Simplified" License
2.42k stars 439 forks source link

Applying Fixes For Skipped Tests Due To Depends #1289

Closed Fenikkusu closed 7 years ago

Fenikkusu commented 7 years ago

Contribution Type: bug fix Link to Intent to Implement: N/A Link to Bug: N/A

This pull request affects the following areas:

In raising this pull request, I confirm the following (please check boxes):

Detailed description of change:

I came across an interesting glitch where in if a primary was skipped, and resulting child (@dependsOn), the tap parser considered the skipped child tests as failed tests. This adds the logic to ensure that those are considered passing.

Fenikkusu commented 7 years ago

Side Note: Given Pull Request #1275, This is likely no longer required.