Not Enough Space - Githubissues

dancryer / PHPCI

PHPCI is a free and open source continuous integration tool specifically designed for PHP.

BSD 2-Clause "Simplified" License

2.42k stars 439 forks source link

Not Enough Space #131

Closed jaitaiwan closed 11 years ago

jaitaiwan commented 11 years ago

When dealing with large repositories (say 2 or more gb) on a server that might have a 40gb hard drive; doing builds can become quite expensive because we aren't cleaning up a build when it's complete.

This can be especially annoying on *nix based OS's where sections of the system are in separate partitions. A.k.a. the root "/" directory might only be 2gb in partition size where the /home directory might be 15gb etc.

Possible solutions are:

Create a plugin which can be invoked on build completion to remove the build's dir
Create a config variable which allows the build to be cleaned up when complete
Do a pre-build disk space check somehow and warn the user before completing the build

I will most likely end up doing a pull request for this as I will probably need this functionality within the next 4 weeks.

dancryer commented 11 years ago

Hi @jaitaiwan - I'm a little confused by this one, as the last stage of every build job deletes the temporary build folder. Is your setup not doing so?

What kind of build are you using? Remote? Local? Also does the user that runs the build jobs have permission to delete?

tobiastom commented 11 years ago

One thing to add, which I'm not sure if it exists, is a way to configure the build directory.

jaitaiwan commented 11 years ago

@dancryer On my installation I'm using local repositories; the build folder still contains the builds, but also the modification I wrote for the local repository plugin doesn't remove files created in the /tmp folder which is also an issue.

@tobiastom I think that's mentioned in another issue.

dancryer commented 11 years ago

I can't help but think this is a local-specific issue, as PHPCI does remove builds by default.

I'm going to close this, but feel free to reopen if you disagree. :)

jaitaiwan commented 11 years ago

Hi Dan,

This is a local specific issue but technically a bug because of the code I provided (9b458060fd9dbc8b97e8376581624c30a4173f6d) for checking out local repositories.

Here's a checklist of what needs to happen:

[ ] Rather than checking repository out to /tmp then copying to ./build either checkout directly to ./build or use the /tmp folder that we're already creating
[ ] Do a folder space check before using /tmp (irrelevant depending on the outcome of the first tick box)
[ ] Remove any folders created in /tmp dir

That would fix the above situation I'm describing I believe.