Changes:
.- ProjectController::build: now also checks GET-vars for chosen branch name
.- Project/view: changed link on "build now": when a different branch is chosen, then send it through GET-vars, so slashes are not a problem
Contribution Type: bug fix
Link to Intent to Implement:
Link to Bug:
This pull request affects the following areas:
[x] Front-End
[ ] Builder
[ ] Build Plugins
In raising this pull request, I confirm the following (please check boxes):
[x] I have checked that another pull request for this purpose does not exist.
[x] I have considered, and confirmed that this submission will be valuable to others.
[x] I have created or updated the relevant documentation for this change on the PHPCI Wiki.
[x] Do the PHPCI tests pass?
Detailed description of change:
In Git, slashes are allowed in branch names, but when such a branch name is sent in the URL, Apache sends a 404 automatically, unless the AllowEncodedSlashes directive is set.
A solution is to send that variable as GET-var, so instead of /project/build/2/feature%2ffoo%2fbar, we use /project/build/2?branch=feature%2ffoo%2fbar.
Changes:
.- ProjectController::build: now also checks GET-vars for chosen branch name (old behaviour still works)
.- Project/view: changed link on "build now": when a different branch is chosen, then send it through GET-vars, so slashes are not a problem
Changes: .- ProjectController::build: now also checks GET-vars for chosen branch name .- Project/view: changed link on "build now": when a different branch is chosen, then send it through GET-vars, so slashes are not a problem
Contribution Type: bug fix Link to Intent to Implement: Link to Bug:
This pull request affects the following areas:
In raising this pull request, I confirm the following (please check boxes):
Detailed description of change: In Git, slashes are allowed in branch names, but when such a branch name is sent in the URL, Apache sends a 404 automatically, unless the AllowEncodedSlashes directive is set. A solution is to send that variable as GET-var, so instead of /project/build/2/feature%2ffoo%2fbar, we use /project/build/2?branch=feature%2ffoo%2fbar. Changes: .- ProjectController::build: now also checks GET-vars for chosen branch name (old behaviour still works) .- Project/view: changed link on "build now": when a different branch is chosen, then send it through GET-vars, so slashes are not a problem