Closed gplanchat closed 7 years ago
Hi @gplanchat
I realise you've closed this pull request, but I wanted to reply in hope that you'd see it...
I'm very much supportive of the work you're doing here, switching to Symfony seems like a sensible plan, and I fully embrace the idea of forking PHPCI to continue its improvement. In many ways I'd be supportive of handing over control of the PHPCI project to someone else to develop now that I am struggling to manage it myself.
However I want to make very clear that just because there is a permissive licence in place doesn't mean that you're allowed to remove our copyright from the code, nor change the copyright message in the licence. You can add your own additional copyright to the files you've changed, but removing ours is not acceptable.
Please, if you intend to continue your project - just respect that request and you'll have my support.
Thanks
Dan
Hello @dancryer,
I understand what you mean and there is no intent to remove the credit on your work. What I am doing is much more for internal use in my company, not for a public release hence the namespaces changes. The PR has been closed because I've mistaken the destination repository.
Contribution Type: bug fix | new plugin | new feature | refactor | cosmetic Link to Intent to Implement: Link to Bug:
This pull request affects the following areas:
In raising this pull request, I confirm the following (please check boxes):
Detailed description of change: