dancryer / PHPCI

PHPCI is a free and open source continuous integration tool specifically designed for PHP.
BSD 2-Clause "Simplified" License
2.42k stars 441 forks source link

PHP-Parallel-Lint shorttags option #1339

Open Dave13h opened 7 years ago

Dave13h commented 7 years ago

Before submitting your issue, please make sure that you've checked all of the checkboxes below.

To help us better understand your issue, please answer the following.

Expected behaviour

There is no option to pass -s to php-parallel-lint, so even if the server supports php shorttags, the linter will fail if you use shorttags.

Actual behaviour

php-parallel-lint will fail with various php parse errors like unexpected end of file if you open an if statement in a <?php section (typically the opening line of the file?) and close it in a <? section.

Steps to reproduce

<?php
if (true): ?>
Hello PHPCI
<? endif; ?>

Environment info

Operating System: Debian GNU/Linux 7.11 (wheezy) PHP Version: 5.6.31 MySQL Version: n/a

PR

https://github.com/Block8/PHPCI/pull/1338

Gummibeer commented 6 years ago

I think that this isn't a real issue - related to the php documentation these are removed in php-7.0.0 http://php.net/manual/en/language.basic-syntax.phptags.php Cause of the fact that 5.6 and 7.0 are just in security phase and end of the year they are out of date it is bad practice to use short-tags any more.