fix regex for parsing gitlab access informations - Githubissues

dancryer / PHPCI

PHPCI is a free and open source continuous integration tool specifically designed for PHP.

BSD 2-Clause "Simplified" License

2.42k stars 441 forks source link

fix regex for parsing gitlab access informations #1351

Open gabrhel opened 5 years ago

gabrhel commented 5 years ago

Contribution Type: bug fix Link to Intent to Implement: none Link to Bug: https://github.com/dancryer/PHPCI/issues/1143

This pull request affects the following areas:

[ ] Front-End
[x] Builder
[ ] Build Plugins

In raising this pull request, I confirm the following (please check boxes):

[x] I have read and understood the contributing guidelines?
[x] I have checked that another pull request for this purpose does not exist.
[x] I have considered, and confirmed that this submission will be valuable to others.
[x] I have created or updated the relevant documentation for this change on the PHPCI Wiki.
[x] Do the PHPCI tests pass?

Detailed description of change:

changed regex for correct parse ports and vendors starting with number .
added 2 tests for parsing gitlab ssh address.