dancsi / OrthoCCTools

Computational coiled-coil peptide design toolkit, written in modern C++
https://www.dancsi.net/icipa
MIT License
3 stars 2 forks source link

bcipa score function and alignments #16

Open ajasja opened 6 years ago

ajasja commented 6 years ago

Bcipa is returning strange results when testing different alignments.

image

While the correct pattern should be

image

bcipa.zip

dancsi commented 6 years ago

Yes, I saw it later, that is why I removed the comment.

On Sat, Dec 23, 2017 at 12:48 PM Ajasja Ljubetič notifications@github.com wrote:

It's allready uploaded at https://github.com/dancsi/DiplomaThesis/files/1555271/bcipa.zip

On 23 December 2017 at 11:24, Daniel Siladji notifications@github.com wrote:

Could you upload the fasta file for these peptides?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/dancsi/DiplomaThesis/issues/16#issuecomment-353718643>, or mute the thread < https://github.com/notifications/unsubscribe-auth/AABN1okDgXj6WOTdYrAKvLQacHsQ3iyRks5tDNTAgaJpZM4RAYt3

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dancsi/DiplomaThesis/issues/16#issuecomment-353722097, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYupDrISPlAW1V2D4fz689EOkbyKGQAks5tDOiZgaJpZM4RAYt3 .

dancsi commented 6 years ago

Anyway, this seems to be fixed in the latest commit. Actually when you disregard the whitespace changes, this was just a simple case of an uninitialized array. Here are the score metrices for potapov: potapov and bCIPA: bcipa Note that this is without fixing #19