nus-pe-bot
commented
2 years ago Team's Response
Thank you for your suggestion. The assumption behind this design is that the student ID field is only required for students who are under the TA's charge. If the TA calls remove_student, the assumption is that the student removed is no longer the TA's student. The TA would not need to know the student ID of a regular contact who is not under his/her teaching charge as the student ID is only used for keeping an official record of the student's grades and attendance. Keeping the student ID for a regular contact adds unnecessary information to the contact and might violate the privacy of the contact.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
In the current implementation, the student ID is tied only when a person is assigned to a class, as as seen with the Person's information not having a student ID
The student ID is only assigned when the person is assigned a class, through a command like
add_student n/Alex Yeoh id/e1231233 tn/cs2103Since a student ID is part of the particulars of a student, and that this app purpose is for TAs to manage their contacts, I would think that student ID should be assigned to a person when it is created (if the argument were to be made that not all people added are students of NUS, since its for TAs to manage their contacts, then the ID field can be optional), rather than only assigning the ID after the student-> class associtation is made
As a result of this, if a class is deleted, the student ID of the student is also deleted, which is not an ideal scenario as the student ID is tied to a user.