search

dandavies23 / smoothie-moves

A smoothie-themed memory game for 4-year-olds
2 stars 3 forks source link

solution to your stackoverflow problem #16

Closed Y0ursTruly closed 3 years ago

Y0ursTruly commented 3 years ago

Pls do see if it works :D

dandavies23 commented 3 years ago

I'm afraid it didn't work. But thanks for your help!

Y0ursTruly commented 3 years ago

ok.. i see what's going on.. mb I'm gonna make another pull request ;-;

dandavies23 commented 3 years ago

Thank you. I've just worked out the double-tap issue basically compared the data-id and thrown up and alert for it (just committed). Now a remaining bug is that if you tap into a blank space a fruit or veg re-appears! Perhaps null can help here?

dandavies23 commented 3 years ago

https://github.com/dandavies23/smoothie-moves/issues/10 for reference

Y0ursTruly commented 3 years ago

im not seeing this error? if i click outside the cups nothing happens.. could u send a screenshot of this error?

Y0ursTruly commented 3 years ago

nvm i see what u mean.. working on it...

dandavies23 commented 3 years ago

It's if you click the area where a match has been found. I'm on phone (again!) but here for example a pair has been found (Score=1) but if I click into an empty space the lemon is back image if I then select another fruit or veg it replaces the found lemon with a cup... image

dandavies23 commented 3 years ago

By "empty space" I mean where the lemon was...

Y0ursTruly commented 3 years ago

yea, merge that new pull request.. what I did is that I return null if the src of the image is the blank image example found in https://sufficientidenticalguiltware.paultaylor2.repl.co/

dandavies23 commented 3 years ago

Thanks for this it's now working. It was my first time "merging". Hope I did it correctly :)

On Wed, 16 Jun 2021 at 01:08, Y0ursTruly @.***> wrote:

yea, merge that new pull request.. what I did is that I return null if the src of the image is the blank image example found in https://sufficientidenticalguiltware.paultaylor2.repl.co/

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/dandavies23/smoothie-moves/pull/16#issuecomment-861913284, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEKGRTSYV2PHQPAUARCHE3TS7TP5ANCNFSM46XVAPAA .