search

dandavison / delta

A syntax-highlighting pager for git, diff, grep, and blame output
https://dandavison.github.io/delta/
MIT License
21.82k stars 364 forks source link

🚀 Windows: Delta default settings hard to read #1488

Closed lesleyrs closed 1 year ago

lesleyrs commented 1 year ago

git diff (delta) image git diff | delta --side-by-side --diff-highlight image git diff | delta --side-by-side --diff-so-fancy image

The above are much harder to read than without delta, although there's no side-by-side feature: image

With default settings I mean this: https://github.com/dandavison/delta#get-started

dandavison commented 1 year ago

Hi @lesleyrs, if I understand correctly I think you're highlighting two issues here:

  1. When using a dark terminal background with default delta theme, the contrast between background colors and highlighted background sections, and foreground text in delta can be a bit poor. I agree; please have a look at the custom themes that users have created: https://dandavison.github.io/delta/custom-themes.html and also see https://github.com/dandavison/delta/issues/481

  2. When you use --side-by-side --diff-highlight something is wrong with your color output. This is not a bug in delta; I think your terminal emulator is failing to display something correctly; perhaps it doesn't support 24-bit color ("truecolor"). See https://dandavison.github.io/delta/tips-and-tricks/24-bit-color-truecolor.html

I would love help with finding better dark-background defaults. Honestly that might be one of the biggest improvements to delta that could be made since most people use dark terminal backgrounds (for whatever reason I use light backgrounds and delta is very readable with the default light theme; do try that if you are not opposed to light backgrounds).

I'll close this since the subject is addressed in the links above, and I believe that the display bug you're seeing is not a delta bug. But I'm always happy to continue discussing in closed tickets.