search

dandavison / delta

A syntax-highlighting pager for git, diff, grep, and blame output
https://dandavison.github.io/delta/
MIT License
22.74k stars 380 forks source link

Upgrade bytelines to latest, without default features #1597

Closed whitfin closed 7 months ago

whitfin commented 9 months ago

Hi there! I found this project via an issue opened here: https://github.com/whitfin/bytelines/pull/7 (totally a mistake on my part).

I've finally resolved this temporarily, by adding a feature for Tokio. It's still enabled by default to avoid a breaking change, but this means that you can now disable default features to exclude Tokio + relevant dependencies. Figured I'd file it here so you no longer have to specifically pin a version going forward.

At some point (time permitting) there will be a bytelines v3 which does this more correctly, but for now it'll be one less thing to think about on your end! I'm not sure if you want the Cargo.lock changes committed, but I can drop those out as necessary.

Thank you!

dandavison commented 7 months ago

Thanks @whitfin and thanks for bytelines!