dandavison / magit-delta

Use delta (https://github.com/dandavison/delta) when viewing diffs in Magit
MIT License
285 stars 10 forks source link

Colours are too dark when using a dark theme #24

Open Atemu opened 2 years ago

Atemu commented 2 years ago

Here's how magit-delta looks in spacemacs using the spacemacs-dark theme:

Screenshot 2022-06-25 at 14 45 22

This is how it looks in macOS Terminal.app:

Screenshot 2022-06-25 at 14 54 21

As you can see, the colours are much darker and not true to the original. (Especially the green/red background colour.)

As part of troubleshooting, I removed --true-colour always from the magit-delta-delta-args which did greatly help the background colours but the syntax highlighting is still a little off.

Screenshot 2022-06-25 at 14 51 42

I've also noticed that the background colourisation doesn't go all the way to the end of the line in magit while it does in the terminal. Why is that?