Performance issue on diff with 40k lines

dandavison / magit-delta

Use delta (https://github.com/dandavison/delta) when viewing diffs in Magit

MIT License

284 stars 10 forks source link

Performance issue on diff with 40k lines #26

Open jumper047 opened 8 months ago

jumper047 commented 8 months ago

Title says it all - recently I faced really big diff, like 40k lines changed, and magit buffer became completely unusable. I disabled magit-delta mode, and everything became usable again. Maybe we should have something like magit-delta-max-diff-size parameter?

dandavison commented 8 months ago

Hi @jumper047, yes I sympathise with this. I'd be happy to review a PR.

jumper047 commented 8 months ago

@dandavison done:)

igorcafe commented 1 month ago

Same problem here. I think the diff should be lazy loaded when we press tab here, instead of loading automatically as I guess its doing. Is it possible to do in magit?

Here, I think its loading this retroarch configs that are huge and I'm not even seeing it, and its very laggy