search

dandavison / magit-delta

Use delta (https://github.com/dandavison/delta) when viewing diffs in Magit
MIT License
288 stars 10 forks source link

Tweak colors #29

Closed haplo closed 7 months ago

haplo commented 7 months ago

First of all, thanks for this great package!

Everything works well, but colors are a bit too dark. Compare:

Regular Magit diff: image

magit-delta diff: image

This might be my theme (solarized-dark from doom-themes), but I would expect the colors to be brighter. Is it possible to tweak them? Any hints at where to look?

Thanks!

dandavison commented 7 months ago

Hi @haplo, glad you're getting value out of magit-delta. I've been using it daily for a few years now. The colors all come from delta itself, so you have the full range of delta options to choose from. You probably want to look at --syntax-theme (for setting the foreground colors) and then all the --*-style options (for setting background colors, etc). For docs, see delta --help and the delta manual, e.g.

https://dandavison.github.io/delta/choosing-colors-styles.html https://dandavison.github.io/delta/custom-themes.html

and you could get some ideas by browsing PRs that add custom themes: https://github.com/dandavison/delta/pulls?q=is%3Apr+theme (they should all have screenshots) and last but not least by looking at the contributed theme configs:

https://github.com/dandavison/delta/blob/main/themes.gitconfig

(closing this ticket but feel free to continue the discussion)

haplo commented 7 months ago

@dandavison Thanks a lot for the thorough reply! Now it makes sense that magit-delta transforms the ANSI color sequences for Emacs to use, so of course :man_facepalming: the colors must be set up in origin.

I believe this information would be useful to have in the README, if you agree I can submit a documentation PR.

dandavison commented 7 months ago

Please do make a documentation PR! The README is pretty minimal right now. FWIW my magit-delta config currently is

(use-package magit-delta
  :after magit
  :config
  (add-hook 'magit-mode-hook (lambda () (magit-delta-mode +1)))
  (add-to-list 'magit-delta-delta-args "--no-gitconfig")
  (add-to-list 'magit-delta-delta-args "--light")
  (setq magit-delta-delta-executable "/opt/homebrew/bin/delta"))