search

dandavison / open-in-editor

Open a local file from a URL at a line number in an editor/IDE
55 stars 8 forks source link

feat: add terminal support for terminal editors #22

Open eugenesvk opened 1 year ago

eugenesvk commented 1 year ago

This gets the terminal path from TERMINAL environment var and wraps the editor command in a terminal command that is specific to that terminal (currently only WezTerm wezterm cli spawn -- editor file:ln:col) but only for terminal editors Path parsing test is added and ReadMe is updated

Not sure what to do with editors that can do both and have the same executable, maybe just remove the terminal not found error and let it spawn the same command as currently so that if the user wants to use the GUI one, he can unset the 'TERMINAL' var? Though that's clunky So I think it's better to require different executable names and adjust our classes accordingly if needed

Closes https://github.com/dandavison/open-in-editor/issues/18

dandavison commented 1 year ago

Interesting!