search

danday74 / envsub

NPM - envsub is envsubst for Node.js
Other
62 stars 10 forks source link

Fix when hash is inner a value of a variable that escaped by quote #19

Open bosure19 opened 4 years ago

bosure19 commented 4 years ago

I found an issue in case of MYVAR="anyvalue#anyvalue" will be compute to "anyvalue instead of anyvalue#anyvalue. so we can't escape hash character

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 8212d443f39e0f98f5a7462456d4eab61d027411 on bosure19:bugfix/escape-hash-on-quote into f699d032bb2413f159ffaf99113a7c8926704d22 on danday74:master.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 33bf94aba6ada58fa7b2c99736e6ff01f619f659 on bosure19:bugfix/escape-hash-on-quote into f699d032bb2413f159ffaf99113a7c8926704d22 on danday74:master.

toniopelo commented 9 months ago

@danday74 Any chance we get this merged ?

danday74 commented 9 months ago

OK the conflict seems fairly easy to resolve and coverage remains at 100%

But merging this won't publish it to npm

I haven't got time to publish to npm

If you give me your npm username then I can add you as a collaborator on npm and you can publish it yourself

Let me know if that works for you, if so I'll merge it