dandeliion-team / dandeliion-client-api-feedback

This private repository is dedicated to collecting feedback, bug reports, and feature requests for dandeliion-client, aiming to track issues, gather user suggestions, and discuss improvements.
0 stars 0 forks source link

Provide information about termination conditions of `solve()` #4

Closed ejfdickinson closed 3 months ago

ejfdickinson commented 3 months ago

Repeat - run with the following:

bpx_file = "nmc_pouch_cell_bpx.json"

experiment = Experiment(
    [
        (
            "Discharge at 12.5 A for 4800 seconds",
        )
    ]
    termination="4800 s",
    period="10 seconds",
)

The model cuts off with a last reported data point at [t = 3736.4, V = 2.6883137].

Can the simulation make it any further than this or is this a point at which the requested current can no longer be delivered at any voltage? Can we get an explanation back from solve() of what prompted the cut-off, e.g. solver convergence failure, or another termination criterion?

jschewts commented 3 months ago

I added a stop_message attribute to solution for the rc3 release that contains the reason for the termination (in human-readable format)