search

dandelion / dandelion-datatables

Dandelion component for DataTables
http://dandelion.github.io/components/datatables/
Other
110 stars 49 forks source link

Not automatically set as "unsearchable" the hidden columns #222

Closed tduchateau closed 10 years ago

tduchateau commented 10 years ago

Issue by dcervera from Friday Nov 08, 2013 at 08:49 GMT

Currently if a column is hidden, automatically it is set as "unsearchable". Why? This behavior cause the property "searchable" of the columns loses its core functionality.

I think the properties "searchable" and "visible" of the columns should be completely independent, allowing developers to combine both in all possible ways, where perhaps the most common combination is "searchable = false" and "visible = false", but this does not justify the inability to use another combination, since, for example, "searchable = true" and "visible = false" can be very useful in many cases.

So I think that it should reconsider changing the behavior so that the hidden columns are not automatically set as "unsearchable".

See #76 for more info. And https://github.com/dandelion/dandelion-datatables/commit/fb5cc50bcff7bcc1e61a92d41e6fbd8a20c35be9 to check the changes made in code.

tduchateau commented 10 years ago

Comment by tduchateau from Sunday Nov 10, 2013 at 12:05 GMT

I think you're right. To be fair, I don't recall why I made this choice...

Thanks :-)

tduchateau commented 10 years ago

Comment by dcervera from Monday Nov 11, 2013 at 15:36 GMT

If you agree with this modification I can try to do the pull-request... :+1:

tduchateau commented 10 years ago

Comment by tduchateau from Monday Nov 11, 2013 at 15:39 GMT

Of course you can! :-) Please submit the PR against the 0.10.0 branch, which is already under active development.

Thanks!