search

danderson / netboot

Packages and utilities for network booting
Apache License 2.0
1.47k stars 181 forks source link

work around broken ipxe EMBED #117

Closed realtime-neil closed 4 years ago

realtime-neil commented 4 years ago

The EMBED option on (at least) the latest ipxe release is broken --- one of its Makefiles eagerly assigns over that variable when it should only be doing so when it's undefined and/or empty. As of this writing, I have an open PR that fixes this issue:

https://github.com/ipxe/ipxe/pull/115

Fortunately, the ipxe developers left a variable in for backward compatibility that we can use instead; i.e., EMBEDDED_IMAGE.

mcb30 commented 4 years ago

https://github.com/ipxe/ipxe/pull/115 seems to be unnecessary: please see comments there.

realtime-neil commented 4 years ago

@mcb30 you're technically correct: it's not needed, but it does beg the question: Why does the current state of affairs allow something like this...

$ EMBEDDED_IMAGE=path/to/my.ipxe make -C ~/code/ipxe/src bin-x86_64-efi/ipxe.efi

...but not this:

$ EMBED=path/to/my.ipxe make -C ~/code/ipxe/src bin-x86_64-efi/ipxe.efi