Fix builds maybe - Githubissues

danderson / netboot

Packages and utilities for network booting

Apache License 2.0

1.47k stars 181 forks source link

Fix builds maybe #96

Closed realtime-neil closed 4 years ago

realtime-neil commented 4 years ago

changed ipxe to be a submodule, updated to latest master
reproducible builds for the four ipxe targets
changed paths on ipxe binaries, updated paths into go-bindata asset maps
changed docker images to use "template" Dockerfile with --build-args
fixed docker image building/pushing targets
fixed error messages in Makefile.inc

realtime-neil commented 4 years ago

@danderson one thing I wanted ask you: I made some decisions about where to put things during the build --- the four ipxe binaries, the go-bindata output, the ARG-riddled Dockerfile. What's "the right place" for such things?

realtime-neil commented 4 years ago

@danderson , also, there's no make target that builds the docker images without pushing them to your registry. You want that? Because I can do that.

danderson commented 4 years ago

I don't remember how the build was broken, but it looks like it's fixed now.