make possible to run it for a specific PR

dandi / dandi-api-webshots-tools

0 stars 0 forks source link

make possible to run it for a specific PR #4

Closed yarikoptic closed 2 years ago

yarikoptic commented 2 years ago

would take a list of prs as an argument (e.g. in our case interested in only one ATM https://github.com/dandi/dandiarchive/pull/857 ATM)
for each {pr}
- git checkout pr-{pr}
- get commit hexsha of current state of that PR
- if that commit differs from recorded (if present in some side car file)
- run webshots collection against https://deploy-preview-{pr}--gui-dandiarchive-org.netlify.app/
- store commit hexsha in side car file
- commit
- git push (I guess we will configure to push all pr- branches in .git/config)

after implemented -- deploy cron job (to run frequently e.g. /5 min) on drogon to run against that 857 and push into dandi-api-webshots-PRs .

PS fancy optional feature -- add option to make script update status of the PR with a URL to that repository/branch. status - green if no errors

jwodder commented 2 years ago

@yarikoptic FYI: In the redesigned Dandiset pages, the "Metadata" button no longer has an ID, which means that the "edit-metadata" jobs all time out.

jwodder commented 2 years ago

@yarikoptic pr-857 branch in PR snapshots repo: https://github.com/dandi/dandi-api-webshots-prs/tree/pr-857

jwodder commented 2 years ago

@yarikoptic Cronjob set up on dandi@drogon.

yarikoptic commented 2 years ago

Thank you! Seems need little fixing when no changes

+ '[' 5f827788ad3580d72092705a0495ab8dce077386 '!=' 5f827788ad3580d72092705a0495ab8dce077386 ']'
+ 'No change to PR 857; doing nothing'
/home/dandi/cronlib/dandi-api-webshots-prs/tools/run-webshots-pr.sh: line 68: No change to PR 857; doing nothing: command not found

jwodder commented 2 years ago

@yarikoptic Fixed.

mvandenburgh commented 2 years ago

@yarikoptic FYI: In the redesigned Dandiset pages, the "Metadata" button no longer has an ID, which means that the "edit-metadata" jobs all time out.

Ah, I didn't notice that when I was copying things over, it's fixed now.

yarikoptic commented 2 years ago

Sweet, https://github.com/dandi/dandi-api-webshots-prs missing any branch, needs push setting in .git/config I guess it just push --all

yarikoptic commented 2 years ago

We have https://github.com/dandi/dandi-api-webshots-prs/tree/pr-857 . Thank you @jwodder!