search

dandi / dandi-archive

DANDI API server and Web app
https://dandiarchive.org
13 stars 9 forks source link

Remove redundancy of environment production values for frontend deployments #1832

Open aaronkanzer opened 7 months ago

aaronkanzer commented 7 months ago

There are two separate places in which environment variables for production are declared:

https://github.com/dandi/dandi-archive/blob/master/web/netlify.toml

https://github.com/dandi/dandi-archive/blob/master/web/.env.production

From Netlify's build process, it seems that the Netlify values are eventually overwritten by the .env.production file (which, by default, gets injected into the Vue app with the yarn run build command during Vite builds.)

The goal of this Issue for now is to capture the redundancy and resolve which values should persist (e.g. should we just remove the values from .env.production)

aaronkanzer commented 7 months ago

Cc @waxlamp @mvandenburgh -- just tagging you both here, as we had discussed via Slack