search

dandi / dandi-archive

DANDI API server and Web app
https://dandiarchive.org
13 stars 10 forks source link

Update our instructions for installation to state newer versions of python and dandi-cli #1919

Closed yarikoptic closed 5 months ago

yarikoptic commented 5 months ago

@dandi/archive-maintainers is there an easy way to avoid hardcoding dandi-cli version here and take it from cli-minimal-version of https://github.com/dandi/dandi-archive/blob/HEAD/dandiapi/api/views/info.py#L65 ?

Change is "inspired" by a user who pointed me to that line which didn't work on his mac with OSX having python 3.7 systemwide

waxlamp commented 5 months ago

@dandi/archive-maintainers is there an easy way to avoid hardcoding dandi-cli version here and take it from cli-minimal-version of https://github.com/dandi/dandi-archive/blob/HEAD/dandiapi/api/views/info.py#L65 ?

Change is "inspired" by a user who pointed me to that line which didn't work on his mac with OSX having python 3.7 systemwide

One way would be to hit the /server-info endpoint and grab the version number from there. @mvandenburgh, @jjnesbitt, @marySalvi, can you think of other ways that don't involve asking the server? Can we build this value into both the server and client by using a common build-time resource somehow?

jjnesbitt commented 5 months ago

One way would be to hit the /server-info endpoint and grab the version number from there. @mvandenburgh, @jjnesbitt, @marySalvi, can you think of other ways that don't involve asking the server? Can we build this value into both the server and client by using a common build-time resource somehow?

Calling /server-info would be the easiest way imo, and isn't really a compromise since the client relies on server up-time anyway.

dandibot commented 5 months ago

:rocket: PR was released in v0.3.84 :rocket: