search

dandi / dandi-archive

DANDI API server and Web app
https://dandiarchive.org
13 stars 10 forks source link

Only include APPROVED users for stats on homepage #1952

Closed aaronkanzer closed 1 week ago

aaronkanzer commented 3 months ago

Cc @kabilar -- per our fix in LINC

The current query on the landing page that shows stats does not filter by user type (e.g. it takes in account REJECTED uers)

This PR includes the proper query.

kabilar commented 3 months ago

Thank you, @aaronkanzer.

Hi @waxlamp, we noticed this behavior on lincbrain.org where the users count on the homepage included those users with a STATUS of APPROVED, PENDING, INCOMPLETE and REJECTED. Presumably the desired behavior is only to count the users who are APPROVED.

yarikoptic commented 2 weeks ago

@aaronkanzer what is your plans for this PR?

kabilar commented 2 weeks ago

@aaronkanzer what is your plans for this PR?

Sorry, @yarikoptic, not sure what you mean. After discussion with @aaronkanzer, he will be coming back to these PRs over the next few weeks.

aaronkanzer commented 1 week ago

@waxlamp thanks for the review -- I've updated the code accordingly to your review.

Cc @kabilar @yarikoptic

dandibot commented 1 week ago

:rocket: PR was released in v0.3.101 :rocket:

kabilar commented 6 days ago

Thanks team. Based on these changes it looks like the number of users listed on the homepage (https://dandiarchive.org/) went from 1908 to 1412.