search

dandi / dandi-archive

DANDI API server and Web app
https://dandiarchive.org
13 stars 10 forks source link

Lock dandisets during un-embargo #1957

Closed jjnesbitt closed 1 week ago

jjnesbitt commented 2 weeks ago

This change will help prevent race conditions that could arise if modifications are allowed while un-embargo is ongoing.

jjnesbitt commented 2 weeks ago

One note: I didn't realize that we prohibit publishing of embargoed Dandisets. I wonder if we should consider lifting that ban--I can see why it would be useful to be able to do so, though the wording we're using makes it confusing ("it's embargoed... how can I be publishing this?") when really "publish" mostly means to create an immutable snapshot.

I thought it was a hard requirement that published dandisets be open access, from more of a NIH policy standpoint.

satra commented 2 weeks ago

I thought it was a hard requirement that published dandisets be open access, from more of a NIH policy standpoint.

yes, embargoed dandisets should not receive a published doi. publishing is only for non-embargoed dandisets.

in the future we may publish restricted dandisets, but we haven't implemented that yet.

to speak about roni's point of freezing versions on embargoed data, that's a different feature which we don't have. we should discuss whether that feature should even exist.

jjnesbitt commented 1 week ago

@waxlamp I had forgotten to include uploads as a part of the locking, as well as prohibit un-embargo in the first place if there were active uploads. Commits ef7c530 and b789645 cover that.

dandibot commented 1 week ago

:rocket: PR was released in v0.3.87 :rocket: