dandi / dandi-cli

DANDI command line client to facilitate common operations
https://dandi.readthedocs.io/
Apache License 2.0
21 stars 25 forks source link

test_update_dandiset_from_doi started to fail #1332

Closed yarikoptic closed 11 months ago

yarikoptic commented 11 months ago

seems started to fail a week ago

FAILED ../../../../../opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/dandi/cli/tests/test_service_scripts.py::test_update_dandiset_from_doi[10.1101/2020.01.17.909838-biorxiv] - AssertionError: assert 1 == 0
368
 +  where 1 = <Result JSONDecodeError('Expecting value: line 1 column 1 (char 0)')>.exit_code
369
FAILED ../../../../../opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/dandi/cli/tests/test_service_scripts.py::test_update_dandiset_from_doi[10.1523/JNEUROSCI.6157-08.2009-jneurosci] - AssertionError: assert 1 == 0
370
 +  where 1 = <Result JSONDecodeError('Expecting value: line 1 column 1 (char 0)')>.exit_code
371
FAILED ../../../../../opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/dandi/cli/tests/test_service_scripts.py::test_update_dandiset_from_doi[10.1016/j.neuron.2019.10.012-neuron] - AssertionError: assert 1 == 0
372
 +  where 1 = <Result JSONDecodeError('Expecting value: line 1 column 1 (char 0)')>.exit_code
373
FAILED ../../../../../opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/dandi/cli/tests/test_service_scripts.py::test_update_dandiset_from_doi[10.7554/eLife.48198-elife] - AssertionError: assert 1 == 0
374
 +  where 1 = <Result JSONDecodeError('Expecting value: line 1 column 1 (char 0)')>.exit_code
375
FAILED ../../../../../opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/dandi/cli/tests/test_service_scripts.py::test_update_dandiset_from_doi[10.1038/s41467-023-37704-5-nature] - AssertionError: assert 1 == 0
376
 +  where 1 = <Result JSONDecodeError('Expecting value: line 1 column 1 (char 0)')>.exit_code
377
= 5 failed, 261 passed, 425 deselected, 1 xfailed, 5 warnings in 631.20s (0:10:31) =

edit: note -- does not fail with 3.8 or 3.9, only fails with 3.10 and 3.11

PytestUnraisableExceptionWarning relating to SSL which I get locally if I remove VCR tape ```shell DEBUG dandi:dandiapi.py:207 GET http://localhost:8000/api/dandisets/000036/versions/draft/ DEBUG dandi:dandiapi.py:269 Response: 200 >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> traceback >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> venvs/dev3.11/lib/python3.11/site-packages/_pytest/runner.py:341: in from_call result: Optional[TResult] = func() venvs/dev3.11/lib/python3.11/site-packages/_pytest/runner.py:262: in lambda: ihook(item=item, **kwds), when=when, reraise=reraise venvs/dev3.11/lib/python3.11/site-packages/pluggy/_hooks.py:493: in __call__ return self._hookexec(self.name, self._hookimpls, kwargs, firstresult) venvs/dev3.11/lib/python3.11/site-packages/pluggy/_manager.py:115: in _hookexec return self._inner_hookexec(hook_name, methods, kwargs, firstresult) venvs/dev3.11/lib/python3.11/site-packages/_pytest/unraisableexception.py:88: in pytest_runtest_call yield from unraisable_exception_runtest_hook() venvs/dev3.11/lib/python3.11/site-packages/_pytest/unraisableexception.py:78: in unraisable_exception_runtest_hook warnings.warn(pytest.PytestUnraisableExceptionWarning(msg)) E pytest.PytestUnraisableExceptionWarning: Exception ignored in: E E Traceback (most recent call last): E File "/home/yoh/proj/dandi/dandi-cli-master/venvs/dev3.11/lib/python3.11/site-packages/vcr/patch.py", line 402, in __exit__ E connection = pool.pool.get() E ^^^^^^^^^^ E ResourceWarning: unclosed ```
yarikoptic commented 11 months ago

I believe it is one of the following upgraded dependencies

❯ wdiff -3 /tmp/f1 /tmp/f2

======================================================================
[-06/github/cron/20231006T060312/0c1d4a0/Tests/5197/test-]{+07/github/cron/20231007T060245/0c1d4a0/Tests/5198/test+}
======================================================================
 [-dependencies.txt:2023-10-06T06:05:18.6948668Z-] {+dependencies.txt:2023-10-07T06:04:51.1091526Z+}
======================================================================
 [-boto3-1.28.61 botocore-1.31.61-] {+boto3-1.28.62 botocore-1.31.62+}
======================================================================
 [-entrypoints-0.4-]
======================================================================
 [-numcodecs-0.11.0-] {+numcodecs-0.12.0+}
======================================================================
 [-urllib3-1.26.17-] {+urllib3-2.0.6+}
======================================================================

deduced from looking at logs collected using con/tinuous on drogon.

github-actions[bot] commented 11 months ago

:rocket: Issue was released in 0.57.0 :rocket: