dandi / dandi-cli

DANDI command line client to facilitate common operations
https://dandi.readthedocs.io/
Apache License 2.0
22 stars 27 forks source link

Update zarr_checksum dependency to `~= 0.4.0` #1393

Closed jwodder closed 10 months ago

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (523f758) 88.50% compared to head (766ef11) 88.59%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1393 +/- ## ========================================== + Coverage 88.50% 88.59% +0.08% ========================================== Files 77 77 Lines 10492 10492 ========================================== + Hits 9286 9295 +9 + Misses 1206 1197 -9 ``` | [Flag](https://app.codecov.io/gh/dandi/dandi-cli/pull/1393/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dandi/dandi-cli/pull/1393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | `88.59% <ø> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yarikoptic commented 10 months ago

why specifically that new version if no changes to the code which uses it?

jwodder commented 10 months ago

@yarikoptic It removes some heavy dependencies from dandi-cli's dependency tree.

yarikoptic commented 10 months ago

I get that, but

so what is the point?

jwodder commented 10 months ago

@yarikoptic

for new user -- it would already install newer lighter version

No, it wouldn't. dandi-cli's current master commit depends on zarr_checksum ~= 0.3.2, which has an upper bound of < 0.4.0.

Another point in favor of this change: zarr_checksum's dependency on boto3 has twice caused dependency issues with backups2datalad and its aiobotocore dependency. In order to permanently avoid this problem, zarr_checksum must be updated to 0.4.0+ for both backups2datalad and dandi (the latter being a dependency of backups2datalad).

yarikoptic commented 10 months ago

No, it wouldn't. dandi-cli's current master commit depends on zarr_checksum ~= 0.3.2, which has an upper bound of < 0.4.0.

for that I guess we would have needed zarr_checksum >= 0.3.2,<0.5 or alike... but ok, if you insist and think that it would make a world a better place for us -- let's proceed.

github-actions[bot] commented 9 months ago

:rocket: PR was released in 0.59.1 :rocket: