search

dandi / dandi-cli

DANDI command line client to facilitate common operations
https://dandi.readthedocs.io/
Apache License 2.0
22 stars 27 forks source link

Clean up URL parsing in `extract_species()` #1416

Closed jwodder closed 8 months ago

jwodder commented 8 months ago

yarl doesn't really seem like it would help with this bit, but I came up with a different way to make the code arguably cleaner.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.61%. Comparing base (2cafb50) to head (a670474).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1416 +/- ## ========================================== + Coverage 88.53% 88.61% +0.07% ========================================== Files 77 77 Lines 10527 10528 +1 ========================================== + Hits 9320 9329 +9 + Misses 1207 1199 -8 ``` | [Flag](https://app.codecov.io/gh/dandi/dandi-cli/pull/1416/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dandi/dandi-cli/pull/1416/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | `88.61% <100.00%> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 8 months ago

:rocket: PR was released in 0.61.0 :rocket: