dandi / dandi-cli

DANDI command line client to facilitate common operations
https://dandi.readthedocs.io/
Apache License 2.0
22 stars 27 forks source link

Convert DOI URLs in `related_publications` to related resources #1417

Closed jwodder closed 8 months ago

jwodder commented 8 months ago

Closes #1308.

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 88.61%. Comparing base (ee18a15) to head (b0bf065).

Files Patch % Lines
dandi/metadata/util.py 82.35% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1417 +/- ## ========================================== + Coverage 88.54% 88.61% +0.06% ========================================== Files 77 77 Lines 10537 10554 +17 ========================================== + Hits 9330 9352 +22 + Misses 1207 1202 -5 ``` | [Flag](https://app.codecov.io/gh/dandi/dandi-cli/pull/1417/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dandi/dandi-cli/pull/1417/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | `88.61% <82.35%> (+0.06%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bendichter commented 8 months ago

LGTM!

jwodder commented 8 months ago

@bendichter Then add an approving review for your review request.

bendichter commented 8 months ago

It's currently marked as WIP

jwodder commented 8 months ago

@bendichter How about now?

jwodder commented 8 months ago

@yarikoptic Ping.

github-actions[bot] commented 6 months ago

:rocket: PR was released in 0.62.0 :rocket: