dandi / dandi-cli

DANDI command line client to facilitate common operations
https://dandi.readthedocs.io/
Apache License 2.0
22 stars 28 forks source link

Revert "Do not allow dandischema 0.10.1 - new schema not yet supporteed by dandi-archive" #1420

Closed yarikoptic closed 8 months ago

yarikoptic commented 8 months ago

This reverts commit ca4c1702e46dae5ca4db2886e2700fe1f408bb31.

dandi-archive supports new schema now, we should be fine to proceed.

jwodder commented 8 months ago

Tests are failing because of connection errors with www.ontobee.org.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.09%. Comparing base (c467402) to head (a40077f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1420 +/- ## =========================================== - Coverage 88.49% 68.09% -20.41% =========================================== Files 77 77 Lines 10537 10522 -15 =========================================== - Hits 9325 7165 -2160 - Misses 1212 3357 +2145 ``` | [Flag](https://app.codecov.io/gh/dandi/dandi-cli/pull/1420/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dandi/dandi-cli/pull/1420/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | `68.09% <ø> (-20.41%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yarikoptic commented 8 months ago

grr.. I don't remember if release CI conditional on tests to pass... let's see

github-actions[bot] commented 8 months ago

:rocket: PR was released in 0.61.1 :rocket:

yarikoptic commented 8 months ago

FWIW, reported