dandi / dandi-cli

DANDI command line client to facilitate common operations
https://dandi.readthedocs.io/
Apache License 2.0
22 stars 27 forks source link

Add missing command to `dandi-archive` docker compose fixture #1421

Closed mvandenburgh closed 8 months ago

mvandenburgh commented 8 months ago

dandi-archive requires this command to be run as part of system initialization in order to initialize the database to serve as a Django cache backend. It must be run in order for any endpoint with caching enabled to work properly. See the set up instructions for docker-compose: https://github.com/dandi/dandi-archive/blob/master/DEVELOPMENT.md#initial-setup

Up until this point, the only endpoint with caching enabled was /api/stats/, and presumably the CLI has no need to hit that in testing so this went unnoticed. However, the rate limiting introduced in https://github.com/dandi/dandi-archive/pull/1899 also makes use of the database cache backend, and thus the CLI tests are failing on that PR.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.09%. Comparing base (23e702e) to head (8b76c82).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1421 +/- ## ========================================== + Coverage 67.96% 68.09% +0.13% ========================================== Files 77 77 Lines 10522 10523 +1 ========================================== + Hits 7151 7166 +15 + Misses 3371 3357 -14 ``` | [Flag](https://app.codecov.io/gh/dandi/dandi-cli/pull/1421/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dandi/dandi-cli/pull/1421/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | `68.09% <100.00%> (+0.13%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yarikoptic commented 8 months ago

Thanks for the PR! Failures seems due to ontobee being still down!

Let's hope we didn't miss any side effect. Marking for release so any downstream testing benefits

github-actions[bot] commented 8 months ago

:rocket: PR was released in 0.61.2 :rocket: