codecov[bot]
commented
6 months ago Codecov Report
Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
Project coverage is 88.63%. Comparing base (
722f1b6) to head (08a4050). Report is 54 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| dandi/download.py | 96.00% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #1443 +/- ## ========================================== + Coverage 88.61% 88.63% +0.01% ========================================== Files 77 77 Lines 10563 10572 +9 ========================================== + Hits 9360 9370 +10 + Misses 1203 1202 -1 ``` | [Flag](https://app.codecov.io/gh/dandi/dandi-cli/pull/1443/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dandi/dandi-cli/pull/1443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | `88.63% <96.15%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
kabilar
github-actions[bot]
Individual commits have more description.
Closes: #1407 . @kabilar could you please check if works for you ok'ish?
edit 1: I think initial OPT commit is not entirely complete -- somewhere in the sandwich of all the generators there is still waiting for an iterable to exhaust itself.