search

dandi / dandi-cli

DANDI command line client to facilitate common operations
https://dandi.readthedocs.io/
Apache License 2.0
22 stars 28 forks source link

Normalize path while requesting list of assets from the server #1454

Closed yarikoptic closed 5 months ago

yarikoptic commented 5 months ago

Closes #1452

See individual commits for more description/rationale.

Related:

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.58%. Comparing base (59f5da0) to head (0aabf16). Report is 49 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1454 +/- ## ========================================== + Coverage 88.47% 88.58% +0.10% ========================================== Files 77 77 Lines 10518 10535 +17 ========================================== + Hits 9306 9332 +26 + Misses 1212 1203 -9 ``` | [Flag](https://app.codecov.io/gh/dandi/dandi-cli/pull/1454/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dandi/dandi-cli/pull/1454/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | `88.58% <100.00%> (+0.10%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yarikoptic commented 5 months ago

ha -- I have missed that my change to test_upload (to actually use ./ in download_directory) which I accidentally committed to test locally broke tests! and rightfully so since normalizing the path lead to side effect in that function... not happy about my solution now but let's proceed by fixing up download_directory for now.

yarikoptic commented 5 months ago

windows -- flaky

________________________ test_IteratorWithAggregation _________________________
dandi\support\tests\test_iterators.py:72: in test_IteratorWithAggregation
    assert got in ([], [0])
E   assert [0, 1] in ([], [0])

---------- coverage: platform win32, python 3.10.11-final-0 ----------
Coverage XML written to file coverage.xml
github-actions[bot] commented 5 months ago

:rocket: PR was released in 0.62.2 :rocket: