Closed jwodder closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.58%. Comparing base (
e2d963d
) to head (ccf4329
). Report is 60 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: PR was released in 0.62.3
:rocket:
Thank you @jwodder !
We really should see if we could somehow reduce such close tie to metadata library in terms of versioning. Hopefully having model expressed as linkml would provide us a remedy so that we could just use corresponding version of the model (like now could be done with jsonschema serialization) supported/requested by the server. Right @candleindark ?
Thank you @jwodder !
We really should see if we could somehow reduce such close tie to metadata library in terms of versioning. Hopefully having model expressed as linkml would provide us a remedy so that we could just use corresponding version of the model (like now could be done with jsonschema serialization) supported/requested by the server. Right @candleindark ?
I am not sure LinkML can solve the particular problem we are facing. The current problem is that the GUI is not accepting the new generated JSON schema generated from Pydantic models. If we have the models expressed in LinkML, the JSON schema will be generated from these models expressed in LinkML instead. You will still have to test the JSON schema against the GUI.
I meant more of being able to test against specific version of schema. We already have jsonschema dumps in https://github.com/dandi/schema/tree/master/releases so in principle, anything which relies on jsonschema alone and is fully compatible with it -- should be able to validate even against versions it didn't see yet before. But with pydantic we cannot really load/use different versions of schema, only "current one", hence rely on "most recent one" and upgrades into it.
I meant more of being able to test against specific version of schema. We already have jsonschema dumps in https://github.com/dandi/schema/tree/master/releases so in principle, anything which relies on jsonschema alone and is fully compatible with it -- should be able to validate even against versions it didn't see yet before. But with pydantic we cannot really load/use different versions of schema, only "current one", hence rely on "most recent one" and upgrades into it.
Yes, in principle that should work. In the backend, assuming you are still using Pydantic models, generated from LinkML, you will need to load different versions of these models from different versions of LinkML schema.
Per @jjnesbitt's advice here
Note that I have added the "release" tag to this PR in order to get this restriction out to users soon.