search

dandi / dandi-cli

DANDI command line client to facilitate common operations
https://dandi.readthedocs.io/
Apache License 2.0
22 stars 27 forks source link

Fix host used in minio URLs #1487

Closed jwodder closed 3 months ago

jwodder commented 3 months ago

Using localhost was causing test failures for me locally when fsspec was involved, likely due to localhost also resolving to ::1, which the minio port was not exposed on.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.62%. Comparing base (37b6350) to head (85f6dd8). Report is 34 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1487 +/- ## ========================================== + Coverage 88.54% 88.62% +0.07% ========================================== Files 77 77 Lines 10565 10565 ========================================== + Hits 9355 9363 +8 + Misses 1210 1202 -8 ``` | [Flag](https://app.codecov.io/gh/dandi/dandi-cli/pull/1487/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dandi/dandi-cli/pull/1487/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | `88.62% <ø> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

:rocket: PR was released in 0.63.1 :rocket: