search

dandi / dandi-cli

DANDI command line client to facilitate common operations
https://dandi.readthedocs.io/
Apache License 2.0
22 stars 27 forks source link

Disallow hdmf 3.14.4, make organize to not parallelize for a single file, log information about all exceptions while reading metadata for organize #1496

Closed yarikoptic closed 2 months ago

yarikoptic commented 2 months ago

Individual commits have more information in their description.

Overall it

I have bundled all the fixes etc so we could return back our CI to green (happen there is more to fix) and release!

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.63%. Comparing base (44e097f) to head (1aa3df8). Report is 6 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1496 +/- ## ========================================== + Coverage 88.55% 88.63% +0.07% ========================================== Files 77 77 Lines 10568 10572 +4 ========================================== + Hits 9359 9371 +12 + Misses 1209 1201 -8 ``` | [Flag](https://app.codecov.io/gh/dandi/dandi-cli/pull/1496/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dandi/dandi-cli/pull/1496/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | `88.63% <100.00%> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yarikoptic commented 2 months ago

well, dev-deps would keep failing until HDMF is fixed up! I think we are ready and should proceed. I will leave it up until tomorrow for a possible review by @asmacdo or @candleindark .

yarikoptic commented 2 months ago

well, 3.12 failed with

=========================== short test summary info ============================
FAILED dandi/tests/test_metadata.py::test_nwb2asset_remote_asset - Failed: Timeout >300.0s

since remote -- may be some connection? but it cannot relate to the changes here

github-actions[bot] commented 2 months ago

:rocket: PR was released in 0.63.1 :rocket: