search

dandi / dandi-cli

DANDI command line client to facilitate common operations
https://dandi.readthedocs.io/
Apache License 2.0
22 stars 28 forks source link

Bump test timeout to 330s #1505

Closed asmacdo closed 2 months ago

asmacdo commented 2 months ago

Python 3.12 tests were becoming flakey

Specifically: dandi/tests/test_metadata.py::test_nwb2asset_remote_asset - Failed: Timeout >300.0s

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.63%. Comparing base (d5c4a3f) to head (7065a3b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1505 +/- ## ========================================== + Coverage 88.56% 88.63% +0.07% ========================================== Files 77 77 Lines 10572 10572 ========================================== + Hits 9363 9371 +8 + Misses 1209 1201 -8 ``` | [Flag](https://app.codecov.io/gh/dandi/dandi-cli/pull/1505/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dandi/dandi-cli/pull/1505/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | `88.63% <ø> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yarikoptic commented 2 months ago

I am afraid it is more systematic etc

asmacdo commented 2 months ago

Thanks @yarikoptic sorry i missed that one.