Closed yarikoptic closed 1 week ago
Attention: Patch coverage is 72.72727%
with 30 lines
in your changes missing coverage. Please review.
Project coverage is 88.51%. Comparing base (
6aa414c
) to head (7f97394
). Report is 25 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
dandi/download.py | 35.71% | 27 Missing :warning: |
dandi/cli/command.py | 0.00% | 1 Missing :warning: |
dandi/dandiapi.py | 80.00% | 1 Missing :warning: |
dandi/tests/test_download.py | 98.33% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
FTR: rebased/force-pushed to get a fresh run of tests after recent changes and drop of 3.8 support.
ok
overall -- we are "ready" here as testing concerned.
:rocket: PR was released in 0.64.0
:rocket:
It was originally developed as part of the PR but derailed into fixing/robustifying download functionality. So sits on top of
1499
TODOs
possibly fold in herefixup for download to do full file checksumming if download was resumed: https://github.com/dandi/dandi-cli/issues/1528