dandi / dandi-cli

DANDI command line client to facilitate common operations
https://dandi.readthedocs.io/
Apache License 2.0
22 stars 28 forks source link

download: more consistent and exhaustive logging, new `DANDI_DEVEL_AGGRESSIVE_RETRY` mode, respect (?) Retry-After #1509

Closed yarikoptic closed 1 week ago

yarikoptic commented 2 months ago

It was originally developed as part of the PR but derailed into fixing/robustifying download functionality. So sits on top of

TODOs

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 72.72727% with 30 lines in your changes missing coverage. Please review.

Project coverage is 88.51%. Comparing base (6aa414c) to head (7f97394). Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
dandi/download.py 35.71% 27 Missing :warning:
dandi/cli/command.py 0.00% 1 Missing :warning:
dandi/dandiapi.py 80.00% 1 Missing :warning:
dandi/tests/test_download.py 98.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1509 +/- ## ========================================== - Coverage 88.58% 88.51% -0.08% ========================================== Files 78 78 Lines 10589 10689 +100 ========================================== + Hits 9380 9461 +81 - Misses 1209 1228 +19 ``` | [Flag](https://app.codecov.io/gh/dandi/dandi-cli/pull/1509/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dandi/dandi-cli/pull/1509/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | `88.51% <72.72%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yarikoptic commented 2 weeks ago

FTR: rebased/force-pushed to get a fresh run of tests after recent changes and drop of 3.8 support.

yarikoptic commented 1 week ago

ok

overall -- we are "ready" here as testing concerned.

github-actions[bot] commented 1 week ago

:rocket: PR was released in 0.64.0 :rocket: