dandi / dandi-cli

DANDI command line client to facilitate common operations
https://dandi.readthedocs.io/
Apache License 2.0
22 stars 28 forks source link

Specify custom ulimit on nofiles to prevent infinite loop by billiard #1533

Closed yarikoptic closed 1 week ago

yarikoptic commented 1 week ago

Closes: https://github.com/dandi/dandi-cli/issues/1488

See: https://github.com/celery/billiard/pull/417

@asmacdo please verify that it resolves the issue for you too

TODOs

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.53%. Comparing base (958adbe) to head (ca1f575). Report is 17 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1533 +/- ## ========================================== + Coverage 88.45% 88.53% +0.07% ========================================== Files 78 78 Lines 10691 10691 ========================================== + Hits 9457 9465 +8 + Misses 1234 1226 -8 ``` | [Flag](https://app.codecov.io/gh/dandi/dandi-cli/pull/1533/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dandi/dandi-cli/pull/1533/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi) | `88.53% <ø> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dandi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

asmacdo commented 1 week ago

With this change, the tests now pass locally for me thank you!

yarikoptic commented 1 week ago

FTR typing error (can't relate) is (new pydantic?):

typing: commands[0]> mypy dandi
dandi/dandiapi.py:1381: error: No overload variant of "PrivateAttr" matches
argument type "None"  [call-overload]
        _metadata: Optional[Dict[str, Any]] = PrivateAttr(default_factory=...
                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~...
dandi/dandiapi.py:1381: note: Possible overload variants:
dandi/dandiapi.py:1381: note:     def [_T] PrivateAttr(default: _T, *, init: Literal[False] = ...) -> _T
dandi/dandiapi.py:1381: note:     def [_T] PrivateAttr(*, default_factory: Callable[[], _T], init: Literal[False] = ...) -> _T
dandi/dandiapi.py:1381: note:     def PrivateAttr(*, init: Literal[False] = ...) -> Any
Found 1 error in 1 file (checked 81 source files)
typing: exit 1 (16.86 seconds) /home/runner/work/dandi-cli/dandi-cli> mypy dandi pid=2089
github-actions[bot] commented 1 day ago

:rocket: PR was released in 0.65.0 :rocket: