Closed yarikoptic closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.53%. Comparing base (
958adbe
) to head (ca1f575
). Report is 17 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
With this change, the tests now pass locally for me thank you!
FTR typing error (can't relate) is (new pydantic?):
typing: commands[0]> mypy dandi
dandi/dandiapi.py:1381: error: No overload variant of "PrivateAttr" matches
argument type "None" [call-overload]
_metadata: Optional[Dict[str, Any]] = PrivateAttr(default_factory=...
^~~~~~~~~~~~~~~~~~~~~~~~~~~~...
dandi/dandiapi.py:1381: note: Possible overload variants:
dandi/dandiapi.py:1381: note: def [_T] PrivateAttr(default: _T, *, init: Literal[False] = ...) -> _T
dandi/dandiapi.py:1381: note: def [_T] PrivateAttr(*, default_factory: Callable[[], _T], init: Literal[False] = ...) -> _T
dandi/dandiapi.py:1381: note: def PrivateAttr(*, init: Literal[False] = ...) -> Any
Found 1 error in 1 file (checked 81 source files)
typing: exit 1 (16.86 seconds) /home/runner/work/dandi-cli/dandi-cli> mypy dandi pid=2089
:rocket: PR was released in 0.65.0
:rocket:
Closes: https://github.com/dandi/dandi-cli/issues/1488
See: https://github.com/celery/billiard/pull/417
@asmacdo please verify that it resolves the issue for you too
TODOs