Related to the recent merge: #841 There are two things that I would like to discuss:
Currently to validate and upload video files we need to specify the option allow-any-path. Since we now explicitly organize video files with dandi organise I dont think this options is a good idea as the user may be able to upload other unwanted files along with videos. Additionally, for this option to work the DANDI_DEVEL env variable needs to exist so any user would need to do: DANDI_DEVEL=1 dandi validate --allow-any-path. This is rather un-user-friendly for common users. (edit by @yarikoptic - dedicated https://github.com/dandi/dandi-cli/issues/920 )
Need to validate video files:
Currently we support the organization of ".mp4", ".avi", ".wmv", ".mov", ".flv" formats. Validation could enforce these extensions. While this list of file containers are only a start, we will build a better list once things get rolling and we encounter different video formats used in animal experiments.
It is theoretically possible for acquisition systems to output corrupted videos: have dropped frames, no frames. Ideally its the users responsibility to correct this so may not be something for DANDI to worry about. These errors could be checked by opening the file using opencv within a try/except block. I am not sure if this happens often enough to make it a necessary check everytime.
we would need to familiarize with opencv on what it depends on for opening video files. If that is some external libraries, then situation might vary widely across systems/installations thus making such validation "fragile".
Related to the recent merge: #841 There are two things that I would like to discuss:
allow-any-path
. Since we now explicitly organize video files withdandi organise
I dont think this options is a good idea as the user may be able to upload other unwanted files along with videos. Additionally, for this option to work theDANDI_DEVEL
env variable needs to exist so any user would need to do:DANDI_DEVEL=1 dandi validate --allow-any-path
. This is rather un-user-friendly for common users. (edit by @yarikoptic - dedicated https://github.com/dandi/dandi-cli/issues/920 )".mp4", ".avi", ".wmv", ".mov", ".flv"
formats. Validation could enforce these extensions. While this list of file containers are only a start, we will build a better list once things get rolling and we encounter different video formats used in animal experiments.try/except
block. I am not sure if this happens often enough to make it a necessary check everytime.