`test_parse_dandi_url_not_found` broken

dandi / dandi-cli

DANDI command line client to facilitate common operations

https://dandi.readthedocs.io/

Apache License 2.0

22 stars 25 forks source link

`test_parse_dandi_url_not_found` broken #967

Closed jwodder closed 2 years ago

jwodder commented 2 years ago

Due to changes in dandi-archive, https://dandiarchive.org/dandiset/999999 no longer returns a 404, and so this test no longer passes:

https://github.com/dandi/dandi-cli/blob/00ee4ddf8785a91ff5bd893497b018ef5fce6437/dandi/tests/test_dandiarchive.py#L323-L327

CC @yarikoptic

jwodder commented 2 years ago

@yarikoptic What exactly do you want me to do for this? Should I just open an issue in dandi-archive?

yarikoptic commented 2 years ago

It seems that the world remains round at the UX level:

$> dandi download https://dandiarchive.org/dandiset/999999
2022-04-20 17:51:37,531 [    INFO] Logs saved in /home/yoh/.cache/dandi-cli/log/20220420215135Z-154310.log
Error: No such Dandiset: '999999'

so let's just announce this test as xfail until closure reached on https://github.com/dandi/dandi-archive/issues/1020

github-actions[bot] commented 2 years ago

:rocket: Issue was released in 0.39.3 :rocket: