Closed yarikoptic closed 2 years ago
@yarikoptic That test is not run against the local Docker setup. The references to Docker in the test's code are for the integration tests with the old redirector.
so you think test would pass after https://github.com/dandi/dandi-archive/pull/1054 merged/deployed?
since placing into production would take time, should we just for now mark it as xfail and then reenable after deployed?
@yarikoptic
so you think test would pass after https://github.com/dandi/dandi-archive/pull/1054 merged/deployed?
Yes.
since placing into production would take time, should we just for now mark it as xfail and then reenable after deployed?
You tell me.
if you have no opinion, then let's indeed proceed with mine of xfail.
:rocket: Issue was released in 0.39.3
:rocket:
now that there is no redirector with hardcoded version and version is reported of dandi-archive itself we hit good old https://github.com/dandi/dandi-archive/issues/222 leading to
https://github.com/dandi/dandi-archive/pull/1054 might be the one to resolve it for the main deployments but I don't know if it would apply to our dockerized server testing since it hardcodes to 0.0.0 in https://github.com/dandi/dandi-archive/pull/1054/files#diff-8fbdfcdd92c90a7625fcf215e3b363869ff8ce725869824d28380b863498d35dR14